Anashkevich natalia detailed page#4
Open
nataliaAnashkevich wants to merge 4 commits intoAnashkevich_Natalia_HomePage_Immerfrom
Open
Anashkevich natalia detailed page#4nataliaAnashkevich wants to merge 4 commits intoAnashkevich_Natalia_HomePage_Immerfrom
nataliaAnashkevich wants to merge 4 commits intoAnashkevich_Natalia_HomePage_Immerfrom
Conversation
csi-sergeykhaustovich
suggested changes
Aug 29, 2022
| {location && <CurrentLocation currentLocation={location}/>} | ||
| {hourlyWeather && | ||
| hourlyWeather.map((hourlyItem, _index) => ( | ||
| <HourlyWeatherItem key={_index} hourly={hourlyItem} /> |
There was a problem hiding this comment.
index is not a good idea to use as a key. Do you have something like id? Or can you generate unique key that will not be changed between calls of the component?
| dispatch(userPositionDetailedWeatherReceived({ hourlyWeather })); | ||
| } catch (error) { | ||
| dispatch(userPositionDetailedWeatherFailed(error)); | ||
| } |
There was a problem hiding this comment.
Let's discuss that by call
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.